Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow newline and quotes for BQ dataset and table descriptions #103

Merged
merged 2 commits into from Jun 24, 2021

Conversation

adlersantos
Copy link
Member

@adlersantos adlersantos commented Jun 24, 2021

Description

As per an internal Friction Friday session where newlines in BQ datasets and descriptions resulted in Terraform complaining about the format.

The tojson method in jinja templates preserves escaped characters such as newlines and quotes.

Checklist

Note: Delete items below that aren't applicable to your pull request.

  • Please merge this PR for me once it is approved.
  • This PR is appropriately labeled.

@adlersantos adlersantos added the bug Something isn't working or open a bugfix label Jun 24, 2021
@leahecole leahecole merged commit ef01fe6 into main Jun 24, 2021
@leahecole leahecole deleted the fix-esc-chars-tf branch June 24, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working or open a bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants