Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup spanner connector to delete duplicate code from google-cloud-spanner library #225

Closed
1 of 2 tasks
tswast opened this issue Apr 1, 2021 · 1 comment
Closed
1 of 2 tasks

cleanup spanner connector to delete duplicate code from google-cloud-spanner library #225

tswast opened this issue Apr 1, 2021 · 1 comment
Assignees
@tswast
Labels
priority: p3 Lowest priority. This can be something deprioritized or not time sensitive. type: cleanup An internal cleanup or hygiene concern.

Comments

@tswast
Copy link
Collaborator

tswast commented Apr 1, 2021 •
edited by nehanene15

Once the following PRs are merged and released, we can delete the duplicate code from the spanner connector:
@tswast tswast self-assigned this Apr 1, 2021
@freedomofnet freedomofnet added Beta priority: p1 High priority. Fix may be included in the next release. type: cleanup An internal cleanup or hygiene concern. labels Jul 14, 2021
@nehanene15 nehanene15 added priority: p3 Lowest priority. This can be something deprioritized or not time sensitive. and removed Beta priority: p1 High priority. Fix may be included in the next release. labels Jun 1, 2022
@nehanene15
Copy link
Collaborator

Duplicate code cleaned up for list_tables(). to_dataframe() seems like a stale PR. If it gets merged we can re-open this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tswast tswast

Labels
priority: p3 Lowest priority. This can be something deprioritized or not time sensitive. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tswast @nehanene15 @freedomofnet