Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spanner Backup & Restore] Codify pontem's version #79

Open
mirons-google opened this issue May 15, 2018 · 4 comments
Open

[Spanner Backup & Restore] Codify pontem's version #79

mirons-google opened this issue May 15, 2018 · 4 comments
Labels
SpannerBackupAndRestore issues related to the spanner backup and restore tool

Comments

@mirons-google
Copy link
Contributor

As we create releases for pontem, we should update (as part of the commits in the release) a change to a global string in pontem that tracks the version.

Then src/main/java/com/google/cloud/pontem/Util.java#L81 should reference that global version string so things between it and util.java stay in sync.

@EricBeach
Copy link
Contributor

Is there a pipeline, etc. that we can use to run tests for this against a release candidate? (I'm looking for a way to automate this instead of just human dependent and I don't see one looking around in GitHub).

@EricBeach EricBeach changed the title Codify pontem's version [Spanner Backup & Restore] Codify pontem's version Nov 3, 2018
@nagarkar
Copy link
Collaborator

Eric, is this still relevant? Is this something an external contributor could do (label with help-wanted/good-first-issue)?

@EricBeach
Copy link
Contributor

I am not sure how relevant it is since we now have so many different subprojects.

@nagarkar nagarkar added the SpannerBackupAndRestore issues related to the spanner backup and restore tool label Jan 25, 2019
@nagarkar
Copy link
Collaborator

I'll close it in that case. Well probably need a new cross platform way to track releases and doing it just for one tool probably isn't the right default option anymore. Michael feel free to reopen if you disagree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SpannerBackupAndRestore issues related to the spanner backup and restore tool
Projects
None yet
Development

No branches or pull requests

3 participants