Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve usability of Google Cloud Operations environment variables #801

Open
NimJay opened this issue Apr 14, 2022 · 4 comments
Open

Improve usability of Google Cloud Operations environment variables #801

NimJay opened this issue Apr 14, 2022 · 4 comments
Assignees
@arbrown
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@NimJay
Copy link
Collaborator

NimJay commented Apr 14, 2022 •
edited

Describe the bug

  • See instructions, Integrating Online Boutique with Google Cloud.
  • A Googler mentioned that they found these environment variables confusing (and thought something was broken):
    • DISABLE_STATS
    • DISABLE_TRACING
    • DISABLE_PROFILER
  • The variables might be confusing because:
    • We're using double negatives. Ideally, the variable names would start with ENABLE_....
    • There is no difference between a value of 0 and a value of 1.

Additional context

Exposure

  • This primarily concerns anyone that wants to enable Google Cloud Operations.
  • This likely only affects a subset of GKE instances (since Google Cloud Operations is disabled by default).
@NimJay NimJay added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Apr 14, 2022
@Shabirmean
Copy link
Member

Potential improvement to the fix, link to the guide in comments.

@minherz
Copy link
Contributor

minherz commented Oct 5, 2022

@Shabirmean the provided link is not working. The file gcp-instrumentation.md is missing in the main branch.

@NimJay
Copy link
Collaborator Author

NimJay commented Oct 6, 2022

Update:
We might be able to address this issue when we bring in OpenTelemtry support.
CC: @arbrown

@arbrown arbrown self-assigned this Oct 10, 2022
@NimJay
Copy link
Collaborator Author

NimJay commented Nov 3, 2022 •
edited

Thank you, @arbrown, for the progress you've made on this so far! :)

Just leaving a screenshot of what's left over as an update:

Screen Shot 2022-11-03 at 10 40 45 AM

@tsmithv11 tsmithv11 mentioned this issue Jul 21, 2023
Open
@bourgeoisor bourgeoisor changed the title Improve Usability of Google Cloud Operations Environment Variables Improve usability of Google Cloud Operations environment variables Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arbrown arbrown

Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@arbrown @minherz @Shabirmean @NimJay