You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 22, 2022. It is now read-only.
By looking at the code and the requests/responses, it was easy to see that the hook did not return a "status" JSON structure -- which led to the error above.
Suggestion: Do not break with a fatal error; but instead log an ERROR message and set the Status to "Error while running webhook: Response malformed" (or so).
In this case, I think omitting "status" from the JSON response should just behave the same as returning an empty status, instead of treating it as an error or invalid response. I've sent PR #132 which should fix that specific issue.
More generally, we intend to better surface hook errors through events (see #7). Currently you can only see them in Metacontroller logs. I prefer putting that in an event because it doesn't reflect the status of the actual object in question, but rather a failure to determine what that status even is.
Hey,
first off, thanks for this great project!
I just ran into an error which crashes Metacontroller, when responsing from a hook with arbitrary JSON:
By looking at the code and the requests/responses, it was easy to see that the hook did not return a "status" JSON structure -- which led to the error above.
Suggestion: Do not break with a fatal error; but instead log an ERROR message and set the Status to "Error while running webhook: Response malformed" (or so).
Related to #91 I guess.
I could also work on this if this is wanted :)
All the best,
Sebastian
The text was updated successfully, but these errors were encountered: