Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make downstream builders short-circuit with success if downstream commit was already built #12360

Open
melinath opened this issue Aug 22, 2022 · 4 comments · May be fixed by GoogleCloudPlatform/magic-modules#10647
Open

Make downstream builders short-circuit with success if downstream commit was already built #12360

melinath opened this issue Aug 22, 2022 · 4 comments · May be fixed by GoogleCloudPlatform/magic-modules#10647
Labels
fixit-technical-debt magician Issues and features related to our bespoke CI size/m technical-debt
Milestone
2024Q2 Fixit

Comments

@melinath
Copy link
Collaborator

Currently, if a downstream builder detects that the corresponding downstream commit was already built, it will fail with an error. Example failure

This means that if one downstream fails due to a transient error, it has to be resolved manually instead of by clicking "retry" on the failed cloudbuild. We should instead consider the downstream builds to be idempotent - if a particular commit has already made it to a downstream, we should consider that a success, since the desired end state has been achieved.
@ScottSuarez
Copy link
Collaborator

related #12359

@rileykarson rileykarson added this to the Near-Term Goals milestone Aug 29, 2022
@rileykarson rileykarson added the magician Issues and features related to our bespoke CI label Mar 28, 2024
@melinath
Copy link
Collaborator Author

I think this change should be fairly easy to make - a lot of the work here will be thinking through whether or not it's actually safe to do. We should also update the documentation around resolving this type of issue to reflect this change.

@melinath melinath mentioned this issue Apr 24, 2024
Closed
@melinath
Copy link
Collaborator Author

If we're also doing #11109 then this should be more clearly safe.

@rileykarson
Copy link
Collaborator

@trodge you'll be touching similar code in #11109. If you have the time, this may be worth picking up as well.

@trodge trodge linked a pull request May 9, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixit-technical-debt magician Issues and features related to our bespoke CI size/m technical-debt
Projects
None yet
Milestone
2024Q2 Fixit
Development

Successfully merging a pull request may close this issue.

Make downstream builder no-op when commit already built trodge/magic-modules
3 participants
@melinath @rileykarson @ScottSuarez