New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting interceptor provider does not include default Spanner interceprtors #6441
Labels
api: spanner
Issues related to the Spanner API.
priority: p1
Important issue which blocks shipping the next release. Will be fixed prior to next release.
🚨
This issue needs some love.
samples
Issues that are directly related to samples.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Comments
product-auto-label
bot
added
the
samples
Issues that are directly related to samples.
label
Dec 1, 2021
Actually it looks like since Oct 7th, we log metrics for GFE latency already... googleapis/java-spanner#1473 |
Neenu1995
added
priority: p1
Important issue which blocks shipping the next release. Will be fixed prior to next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
and removed
triage me
I really want to be triaged.
labels
Dec 2, 2021
@jsimonweb Any updates? This issue is out of SLO. |
Fixed by #6177 - thanks @KiranmayiB |
Could you please explain? I am out of the loop. @nielm |
I raised an issue about one of the Spanner samples. In the meantime you fixed it with PR #6177 :) |
got it. thank you :)
…On Wed, Jan 19, 2022 at 5:00 PM Niel Markwick ***@***.***> wrote:
I raised an issue about one of the Spanner samples. In the meantime you
fixed it with PR #6177
<#6177> :)
So this issue can be closed!
—
Reply to this email directly, view it on GitHub
<#6441 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APWES2DLYWLWI6YHBIHREBDUW2ODTANCNFSM5JEW4CWA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Thanks
Kiranmayi
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: spanner
Issues related to the Spanner API.
priority: p1
Important issue which blocks shipping the next release. Will be fixed prior to next release.
🚨
This issue needs some love.
samples
Issues that are directly related to samples.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
The line setting the interceptor provider at CaptureGfeMetric.java:L67 does not include the default spanner interceptors (error handling and logging)
should be
The text was updated successfully, but these errors were encountered: