Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting interceptor provider does not include default Spanner interceprtors #6441

Closed
nielm opened this issue Dec 1, 2021 · 7 comments
Closed
Assignees
Labels
api: spanner Issues related to the Spanner API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@nielm
Copy link
Contributor

nielm commented Dec 1, 2021

The line setting the interceptor provider at CaptureGfeMetric.java:L67 does not include the default spanner interceptors (error handling and logging)

        .setInterceptorProvider(() -> Collections.singletonList(interceptor))

should be

        setInterceptorProvider(SpannerInterceptorProvider.createDefault().with(interceptor))
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Dec 1, 2021
@nielm
Copy link
Contributor Author

nielm commented Dec 1, 2021

Actually it looks like since Oct 7th, we log metrics for GFE latency already... googleapis/java-spanner#1473

@nielm
Copy link
Contributor Author

nielm commented Dec 1, 2021

@mayurkale22

@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Dec 2, 2021
@Neenu1995 Neenu1995 added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed triage me I really want to be triaged. labels Dec 2, 2021
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Dec 8, 2021
@eaball35
Copy link
Contributor

eaball35 commented Dec 8, 2021

@jsimonweb Any updates? This issue is out of SLO.

@eaball35 eaball35 added the api: spanner Issues related to the Spanner API. label Dec 8, 2021
@lesv lesv closed this as completed Dec 9, 2021
@lesv lesv reopened this Dec 9, 2021
@jsimonweb jsimonweb assigned ansh0l and unassigned jsimonweb Jan 18, 2022
@nielm
Copy link
Contributor Author

nielm commented Jan 19, 2022

Fixed by #6177 - thanks @KiranmayiB

@KiranmayiB
Copy link
Contributor

KiranmayiB commented Jan 19, 2022

Could you please explain? I am out of the loop. @nielm

@nielm
Copy link
Contributor Author

nielm commented Jan 19, 2022

I raised an issue about one of the Spanner samples. In the meantime you fixed it with PR #6177 :)
So this issue can be closed!

@KiranmayiB
Copy link
Contributor

KiranmayiB commented Jan 19, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

10 participants