Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloudEvent registration method should be camelCase #378

Closed
matthewrobertson opened this issue Nov 3, 2021 · 1 comment · Fixed by #379
Closed

CloudEvent registration method should be camelCase #378

matthewrobertson opened this issue Nov 3, 2021 · 1 comment · Fixed by #379

Comments

@matthewrobertson
Copy link
Member

matthewrobertson commented Nov 3, 2021

"Cloud Event" is two words so the "E" should be capitalized:

import * as functions from '@google-cloud/functions-framework';

functions.cloudEvent('helloCloudEvent', (cloudEvent) => {
  console.log('Hello, CloudEvent!');
});
@grant
Copy link
Contributor

grant commented Nov 3, 2021

Nice catch. cloudEvent should be the correct lower camel case. 👍🏻

Note: CloudEvent is one word, but the outcome of using cloudEvent is the same.

https://cloudevents.io/

matthewrobertson added a commit that referenced this issue Nov 5, 2021
This commit is a refactor of all our cloudevent identifiers to be more
consistent. Depending on the context we will always prefer: `CloudEvent`,
`cloudEvent`, or `cloud_event`. We will avoid `cloudevent`

Fixes #378
matthewrobertson added a commit that referenced this issue Nov 5, 2021
This commit is a refactor of all our cloudevent identifiers to be more
consistent. Depending on the context we will always prefer: `CloudEvent`,
`cloudEvent`, or `cloud_event`. We will avoid `cloudevent`

Fixes #378
matthewrobertson added a commit that referenced this issue Nov 5, 2021
This commit is a refactor of all our cloudevent identifiers to be more
consistent. Depending on the context we will always prefer: `CloudEvent`,
`cloudEvent`, or `cloud_event`. We will avoid `cloudevent`

Fixes #378
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants