feat: Add Google CloudEvent Types #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewrobertson
requested review from
asriniva,
grant,
KaylaNguyen and
anniefu
grant
suggested changes
Oct 28, 2021
| * {@link https://github.com/cloudevents/spec/blob/master/spec.md#context-attributes} | ||
| * @public | ||
| */ | ||
| export interface CloudEvent { |
There was a problem hiding this comment.
How is this interface different than the interface here?
https://github.com/GoogleCloudPlatform/functions-framework-nodejs/blob/master/src/functions.ts
There was a problem hiding this comment.
It is the same. My plan is to replace that interface with this one in a subsequent PR. I duplicated it in this PR so that it will revert cleanly. At this point we can rm -rf src/cloudevent_types and nothing is broken.
matthewrobertson
force-pushed
the
add-cloudevent-interfaces
branch
from
e98ae15
to
dce5c26
Compare
anniefu
approved these changes
Oct 29, 2021
This commit adds the output of the experiment/generate_cloudevents pipeline to the FunctionsFrameworks. This adds type interfaces for all known Google CloudEvent payloads, but it does not make any changes to the FFs to consume them yet. Those changes will be made in a subsequent PR. All the types added by this PR can be deleted once the npm packages produced by googleapis/google-cloudevents-nodejs is ready for production usage.
matthewrobertson
force-pushed
the
add-cloudevent-interfaces
branch
from
dce5c26
to
1cc3472
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the output of the experiment/generate_cloudevents pipeline to the nodejs FunctionsFrameworks. This adds type interfaces for all known Google CloudEvent payloads, but it does not make any changes to the FFs to consume them yet. Those changes will be made in a subsequent PR.
All the types added by this PR can be deleted once the npm packages produced by googleapis/google-cloudevents-nodejs is ready for production usage.