Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable traceparent header for cloudevents #336

Merged
merged 8 commits into from Oct 12, 2021

Conversation

grant
Copy link
Contributor

@grant grant commented Sep 28, 2021

Fixes: #197

traceparent is the more modern header that includes information that X-Cloud-Trace-Context references.

Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
@grant grant self-assigned this Sep 28, 2021
@google-cla google-cla bot added the cla: yes label Sep 28, 2021
@grant grant requested a review from anniefu September 30, 2021 17:54
src/function_wrappers.ts Outdated Show resolved Hide resolved
grant and others added 6 commits October 11, 2021 15:57
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
@grant
Copy link
Contributor Author

grant commented Oct 11, 2021

PTAL :)

Copy link
Member

@matthewrobertson matthewrobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grant grant added the automerge Summon MOG for automerging label Oct 12, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit aba9cb4 into master Oct 12, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Summon MOG for automerging label Oct 12, 2021
@grant grant deleted the grant_traceparent_header branch October 15, 2021 19:52
@grant grant restored the grant_traceparent_header branch October 15, 2021 19:52
@grant grant deleted the grant_traceparent_header branch October 21, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose trace IDs in background and cloud event functions
2 participants