refactor!: move function wrapping earlier #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grant
approved these changes
Sep 24, 2021
matthewrobertson
force-pushed
the
function-registration
branch
from
919dc4c
to
96ec507
Compare
This commit extracts the logic for wrapping user functions into its own module and adds unit tests. It also refactors the code path that wraps the user function earlier in the initialization logic. This removes registration from the critical request path.
matthewrobertson
force-pushed
the
function-registration
branch
from
96ec507
to
7ed470e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit extracts the logic for wrapping user functions into its
own module and adds unit tests. It also moves the code path that
wraps the user function earlier in the initialization logic. This
removes user function wrapping from the critical request path.