fix: Do not pass numeric arguments to res.send #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes GoogleCloudPlatform#239. res.send when receiving a sole numeric argument will set thee statuc code to that number. This breaks HTTP communication as some numbers are not valid HTTP response codes. For example, in the original issue the code is being set to 2. Which probably comes from the UNKNOWN error response of an RPC call. This makes that the function is reported as having a `connection error`.
grant
suggested changes
Jan 29, 2021
grant
approved these changes
Jan 29, 2021
|
Will be published in next release of the FF. If there's urgency to publish this, ping here. |
|
found this useful in my application. Gracias |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #239.
res.send when receiving a sole numeric argument will set thee statuc code to that number.
This breaks HTTP communication as some numbers are not valid HTTP response codes.
For example, in the original issue the code is being set to 2. Which probably comes from the UNKNOWN error response of an RPC call.
This makes that the function is reported as having a
connection error.