Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run conformance tests against the current FF version #236

Merged
merged 4 commits into from
Nov 11, 2020

Conversation

hdp617
Copy link
Contributor

@hdp617 hdp617 commented Nov 11, 2020

  • run conformance tests against the current FF version specified by $GITHUB_SHA instead of the default version in buildpacks
  • update conformance action version
  • remove no longer used script
  • remove nodejs14 since this runtime is not yet live and does not have tag :latest.

fixes #231

Otherwise, buildpacks use the default value in PROD, which is not the version being tested.
Also, remove the tag field since the :latest tag was enabled.
@google-cla google-cla bot added the cla: yes label Nov 11, 2020
This is because the runtime is not yet live with tag latest.
@hdp617 hdp617 requested a review from grant November 11, 2020 22:24
@hdp617 hdp617 merged commit 240defc into master Nov 11, 2020
@hdp617 hdp617 deleted the fix-conformance branch November 11, 2020 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conformance tests are running against the buildpack version, not source tree
2 participants