Conformance tests are running against the buildpack version, not source tree #231
Comments
|
See GoogleCloudPlatform/functions-framework-python#95 for another example of how to do this. |
hdp617
added a commit
that referenced
this issue
Nov 11, 2020
* run conformance tests against the current FF version specified by $GITHUB_SHA instead of the default version in buildpacks * update conformance action version * remove no longer used script * remove nodejs14 since this runtime is not yet live and does not have tag :latest. fixes #231
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The conformance tests for this repo are configured to use buildpacks, so they're using the version of this framework that is already released and supported in the buildpack rather than what's in the current source tree.
Instead, the conformance tests should be run locally against the current source tree. For example, this is what the .NET framework does.
This will ensure that we are aware if a given PR breaks the conformance tests, as the status will match the current state of the repo.
The text was updated successfully, but these errors were encountered: