fix: ensure proxy shuts down gracefully on SIGTERM #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurtisvg
reviewed
Aug 9, 2021
enocom
force-pushed
the
graceful-fuse-exit
branch
from
a9b27a8
to
cd8f573
Compare
|
This change ended up being larger than I expected. With the calls to os.Exit, we were actually failing to run any previous defer statements. |
kurtisvg
suggested changes
Aug 10, 2021
enocom
changed the title
kurtisvg
approved these changes
Aug 10, 2021
|
Ran the linting manually. |
kurtisvg
approved these changes
Aug 10, 2021
kurtisvg
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #876