Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate instances in fuse mode #875

Merged
merged 5 commits into from
Aug 9, 2021

Conversation

monazhn
Copy link
Contributor

@monazhn monazhn commented Aug 7, 2021

Change Description

Validate instances in fuse mode to avoid incorrectly picking up file system requests.

Checklist

  • Make sure to open an issue as a
    bug/issue
    before writing your code! That way we can discuss the change, evaluate
    designs, and agree on the general idea.
  • Ensure the tests and linter pass
  • Appropriate documentation is updated (if necessary)

Relevant issues:

Previously, fuse code assumed all file system requests are valid Cloud
SQL instances.
Instance strings must be of the correct format.
Copy link
Member

@enocom enocom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments.

proxy/fuse/fuse.go Outdated Show resolved Hide resolved
proxy/proxy/client.go Outdated Show resolved Hide resolved
@monazhn monazhn requested a review from enocom August 9, 2021 15:40
@enocom enocom requested a review from kurtisvg August 9, 2021 16:29
Copy link
Member

@enocom enocom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@enocom enocom added the automerge Summon MOG for automerging label Aug 9, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 96f8b65 into GoogleCloudPlatform:main Aug 9, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Summon MOG for automerging label Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fuse mode erroneously picks up system directories
3 participants