Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add health checks to proxy #859

Merged
merged 142 commits into from
Aug 3, 2021

Conversation

monazhn
Copy link
Contributor

@monazhn monazhn commented Jul 30, 2021

Change Description

Introduce health checks to the Cloud SQL proxy client, allowing for the proactive and automatic mitigation of health-related issues. The health checks consist of startup, liveness, and readiness probing, with requests against the proxy container issued via HTTP.

Checklist

  • Make sure to open an issue as a bug/issue
    before writing your code! That way we can discuss the change, evaluate
    designs, and agree on the general idea.
  • Ensure the tests and linter pass
  • Appropriate documentation is updated (if necessary)

Relevant issues:

Co-authored-by: Tiffany Xiang tiffanyx@google.com

monazhn and others added 30 commits June 29, 2021 16:49
@enocom enocom requested review from kurtisvg and enocom July 30, 2021 21:36
README.md Outdated Show resolved Hide resolved
Copy link
Member

@enocom enocom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor suggestions on docstrings. Otherwise, LGTM.

cmd/cloud_sql_proxy/internal/healthcheck/healthcheck.go Outdated Show resolved Hide resolved
cmd/cloud_sql_proxy/internal/healthcheck/healthcheck.go Outdated Show resolved Hide resolved
cmd/cloud_sql_proxy/internal/healthcheck/healthcheck.go Outdated Show resolved Hide resolved
@enocom enocom requested a review from kurtisvg August 2, 2021 21:37
@enocom enocom changed the title Add health checks to proxy container feat: add health checks to proxy Aug 3, 2021
@enocom enocom added the automerge Summon MOG for automerging label Aug 3, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit ea62bdd into GoogleCloudPlatform:main Aug 3, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Summon MOG for automerging label Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Add health checks to proxy container
5 participants