fix: ensure certificate expiration is correct #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is a follow-on to #648 which only partially addressed the issue reported in #643. In a previous commit, we ensured the associated OAuth2 token was refreshed before requesting an ephemeral certificate. However, the oauth2.TokenSource stored in certs.RemoteCertSource would nonetheless report an unrefreshed token's expiration. As a result, attempts to refresh the configuration would fail given the unrefreshed token would expire too soon. This commit takes a new approach by updating the leaf certificate's expiration to be the earlier of the ephemeral certificate's expiration or the token's expiration. It likewise removes any checks of the token's expiration outside of certs.RemoteCertSource. Fixes #643.
kurtisvg
approved these changes
Mar 5, 2021
kurtisvg
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is a follow-on to #648 which only partially addressed the
issue reported in #643. In a previous commit, we ensured the associated
OAuth2 token was refreshed before requesting an ephemeral certificate.
However, the oauth2.TokenSource stored in certs.RemoteCertSource would
nonetheless report an unrefreshed token's expiration. As a result,
attempts to refresh the configuration would fail given the unrefreshed
token would expire too soon.
This commit takes a new approach by updating the leaf certificate's
expiration to be the earlier of the ephemeral certificate's expiration
or the token's expiration. It likewise removes any checks of the token's
expiration outside of certs.RemoteCertSource.
Fixes #643.