Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: perform initial gcloud check and reuse token #657

Merged
merged 2 commits into from Mar 5, 2021
Merged

fix: perform initial gcloud check and reuse token #657

merged 2 commits into from Mar 5, 2021

Conversation

kurtisvg
Copy link
Contributor

@kurtisvg kurtisvg commented Mar 5, 2021

Change Description

Reverts behavior to verify a gcloud token is available before using it as a TokenSource, and caches the token when possible.

Checklist

  • Make sure to open an issue as a
    bug/issue
    before writing your code! That way we can discuss the change, evaluate
    designs, and agree on the general idea.
  • Ensure the tests and linter pass
  • Appropriate documentation is updated (if necessary)

Relevant issues:

@google-cla google-cla bot added the cla: yes label Mar 5, 2021
@kurtisvg kurtisvg requested a review from enocom March 5, 2021 04:25
@kurtisvg kurtisvg added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 5, 2021
@enocom enocom added automerge Summon MOG for automerging and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Mar 5, 2021
@enocom enocom merged commit f3bf3f9 into main Mar 5, 2021
@enocom enocom deleted the tok-cache branch March 5, 2021 15:50
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Summon MOG for automerging label Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.20.1 image crashes with: errors parsing config: exec: "gcloud": executable file not found in $PATH
2 participants