Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ARM releases #631

Merged
merged 2 commits into from Feb 24, 2021
Merged

feat: add ARM releases #631

merged 2 commits into from Feb 24, 2021

Conversation

shubha-rajan
Copy link
Contributor

Change Description

Added steps to compile binaries for Linux/ARM32 and Linux/ARM64, as well as Darwin/ARM64. The Linux versions have been tested with QEMU, but not on an actual ARM machine yet.
Not sure how to test the Darwin one (for M1 Macs), although it's probably low priority, since Apple says that the new Macs have Rosetta to run programs compiled for AMD64.

Checklist

  • Make sure to open an issue as a
    bug/issue
    before writing your code! That way we can discuss the change, evaluate
    designs, and agree on the general idea.
  • Ensure the tests and linter pass
  • Appropriate documentation is updated (if necessary)

Copy link
Member

@enocom enocom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -19,7 +19,7 @@ options:

steps:
- id: linux.amd64
name: "golang:1.14"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a particular reason we'd pinned to Go 1.14 here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was specifically because Go dropped support for cross-compiling for 32-bit Darwin in 1.15. So we decided to compile all of them with the same version, but at our last team sync, we decided to compile all other binaries with 1.16 except for the darwin.386 one

@kurtisvg
Copy link
Contributor

Can we separate this into 2 prs? One for moving the version we compile with to 1.16 and one for adding the ARM releases? Seems like it should be 2 different items in the release notes

@kurtisvg
Copy link
Contributor

We should also add Go 1.16 tests before we use that to compile, just in case :)

@kurtisvg kurtisvg added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 24, 2021
@shubha-rajan shubha-rajan changed the title feat: add ARM releases and update Go version for compiling to 1.16 feat: add ARM releases Feb 24, 2021
@shubha-rajan
Copy link
Contributor Author

We should also add Go 1.16 tests before we use that to compile, just in case :)

Adding those this afternoon! We'll merge #634 after tests pass.

@shubha-rajan shubha-rajan removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 24, 2021
@shubha-rajan shubha-rajan merged commit d3fb7f6 into main Feb 24, 2021
@shubha-rajan shubha-rajan deleted the arm-releases branch February 24, 2021 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants