New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ARM releases #631
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
.build/gcs_upload.yaml
Outdated
@@ -19,7 +19,7 @@ options: | |||
|
|||
steps: | |||
- id: linux.amd64 | |||
name: "golang:1.14" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there a particular reason we'd pinned to Go 1.14 here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was specifically because Go dropped support for cross-compiling for 32-bit Darwin in 1.15. So we decided to compile all of them with the same version, but at our last team sync, we decided to compile all other binaries with 1.16 except for the darwin.386
one
Can we separate this into 2 prs? One for moving the version we compile with to 1.16 and one for adding the ARM releases? Seems like it should be 2 different items in the release notes |
We should also add Go 1.16 tests before we use that to compile, just in case :) |
8ac73e2
to
1d9ee45
Compare
Adding those this afternoon! We'll merge #634 after tests pass. |
Change Description
Added steps to compile binaries for Linux/ARM32 and Linux/ARM64, as well as Darwin/ARM64. The Linux versions have been tested with QEMU, but not on an actual ARM machine yet.
Not sure how to test the Darwin one (for M1 Macs), although it's probably low priority, since Apple says that the new Macs have Rosetta to run programs compiled for AMD64.
Checklist
bug/issue
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea.