Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return publisher with shutdown status on connection close #258

Closed
elefeint opened this issue Aug 12, 2020 · 1 comment · Fixed by #365
Closed

Return publisher with shutdown status on connection close #258

elefeint opened this issue Aug 12, 2020 · 1 comment · Fixed by #365
Labels
feature New functionality P3 V2
Milestone
0.5.0

Comments

@elefeint
Copy link
Contributor

In SpannerClientLibraryConnection.close(), listen for various shutdowns and propagate them to the returned Publisher. Check what other drivers are doing.
@elefeint elefeint added the feature New functionality label Oct 6, 2020
@elefeint
Copy link
Contributor Author

After googleapis/java-spanner#505 went in, the AsyncTransactionManager.closeAsync() variant is now available. Use its returned future to propagate closure status back to R2DBC primitives.

@elefeint elefeint added this to the 0.4.0 milestone Nov 24, 2020
@elefeint elefeint mentioned this issue May 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New functionality P3 V2
Projects
None yet
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

Remove custom thread pools GoogleCloudPlatform/cloud-spanner-r2dbc
1 participant
@elefeint