Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate statement parsing to the official connection API one #236

Closed
elefeint opened this issue Apr 21, 2020 · 1 comment · Fixed by #237
Closed

Migrate statement parsing to the official connection API one #236

elefeint opened this issue Apr 21, 2020 · 1 comment · Fixed by #237
Assignees
@elefeint
Labels
V2

Comments

@elefeint
Copy link
Contributor

Use com.google.cloud.spanner.connection.StatementParser instead of the custom one currently in use.
@elefeint elefeint self-assigned this Apr 21, 2020
@elefeint
Copy link
Contributor Author

With @dmitry-s , identified a slight difference in parsing: googleapis/java-spanner#163

@elefeint elefeint mentioned this issue Apr 21, 2020
Merged
elefeint added a commit that referenced this issue Apr 23, 2020
@elefeint
Switch StatementParser to pass through to the facade (#237)
5f24289 
Co-authored-by: @dmitry-s

Updates to the latest Cloud Spanner client library and uses its Connection API to check query type.

Also updates cloud libraries BOM, but it has not had time to pull in the newest Cloud Spanner client library, so an override is needed.


Fixes #236.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elefeint elefeint

Labels
V2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch StatementParser to pass through to the facade GoogleCloudPlatform/cloud-spanner-r2dbc
1 participant
@elefeint