Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll out tag bindings to all supported resources #2157

Closed
juliocc opened this issue Mar 15, 2024 · 3 comments
Closed

Roll out tag bindings to all supported resources #2157

juliocc opened this issue Mar 15, 2024 · 3 comments

Comments

@juliocc
Copy link
Collaborator

juliocc commented Mar 15, 2024

[see below comment for details]

@ludoo ludoo changed the title Support tag bindings in bigquery-dataset Roll out tag bindings to all supported resources Mar 22, 2024
@ludoo
Copy link
Collaborator

ludoo commented Mar 22, 2024

We should support most of the services/resources listed here, excluding those in alpha (which are quite a few).

  • alloydb
  • bigquery
  • bigtable
  • cloud-run
  • coud-run-v2
  • gcs
  • kms

The compute resources (forwarding rules, disks, etc.) need to expose the generated (numeric) id which is not currently available everywhere (backend services have it, forwarding rules and disks don't, etc.). An FR needs to be opened on the provider to implement exhaustive support for generated ids on all relevant resources before tag bindings can be implemented. For instance support, see the comment in the compute-vm module.

@ludoo
Copy link
Collaborator

ludoo commented May 25, 2024

@simonebruzzechesse can you implement support for alloydb? I know you're testing it for a customer so you might have instances up already, which I don't have.

@ludoo
Copy link
Collaborator

ludoo commented May 29, 2024

Closing this while Julio figures out if it's worth adding support for numeric ids to compute resources. Alloydb and bigtable will be done if/when there's a need for them, no point keeping this issue open.

@ludoo ludoo closed this as completed May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants