Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable buildpacks for python django guestbook sample #393

Open
sivakku opened this issue Jul 29, 2020 · 2 comments
Open

Enable buildpacks for python django guestbook sample #393

sivakku opened this issue Jul 29, 2020 · 2 comments
Assignees
Labels
lang: python Issues specific to Python. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@sivakku
Copy link
Contributor

sivakku commented Jul 29, 2020

From cloud-code-vscode-internal created by j-windsor: GoogleCloudPlatform/cloud-code-vscode-internal#2642

Because of the implementation of the k8s Job waiting to do django migrate, we need to set /bin/sh -c entrypoint in dockerfile so we can specify args: ["python manage.py migrate"] in the migration job and it will run successfully for both buildpacks and docker.

This is currently blocked by GoogleContainerTools/skaffold#4397

@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Jul 30, 2020
@j-windsor j-windsor added priority: p0 Highest priority. Critical issue. P0 implies highest priority. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. lang: python Issues specific to Python. and removed 🚨 This issue needs some love. bug july-chill p2 triage me I really want to be triaged. labels Aug 21, 2020
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Aug 21, 2020
@j-windsor j-windsor assigned j-windsor and kelsk and unassigned j-windsor Aug 21, 2020
@simonz130 simonz130 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Aug 24, 2020
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Aug 24, 2020
@kelsk
Copy link
Contributor

kelsk commented Feb 11, 2021

Investigating how to implement buildpacks - it might be more secure to use an entrypoint other than /bin/sh -c

@kelsk kelsk added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. and removed priority: p0 Highest priority. Critical issue. P0 implies highest priority. labels Feb 11, 2021
@engelke
Copy link
Contributor

engelke commented May 5, 2022

Looking at the referenced issues and the time elapsed, it seems like this issue may have been handled elsewhere but not updated here. Assigning back to j-windsor to route to a knowledgeable person or close as handled.

@engelke engelke assigned j-windsor and unassigned kelsk May 5, 2022
@averikitsch averikitsch added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang: python Issues specific to Python. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

7 participants