Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updates function name for remove-annotated-resources #85

Merged

Conversation

g-awmalik
Copy link
Contributor

Updates the function name/image to: gcr.io/kpt-fn/remove-local-config-resources:v0.1

@g-awmalik g-awmalik requested review from askmeegs and a team as code owners November 4, 2021 05:21
@g-awmalik
Copy link
Contributor Author

/assign @bharathkkb

@g-awmalik
Copy link
Contributor Author

@bharathkkb - PTAL

@bharathkkb bharathkkb changed the title fix:updates function name for remove-annotated-resources fix: updates function name for remove-annotated-resources Nov 4, 2021
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge after testing the hydration pipeline

@google-oss-prow google-oss-prow bot added the lgtm label Nov 4, 2021
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bharathkkb, g-awmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@google-oss-prow google-oss-prow bot removed the lgtm label Nov 9, 2021
@g-awmalik
Copy link
Contributor Author

Tested locally using the Landing Zone blueprint and it works well.

@g-awmalik g-awmalik merged commit 1632e00 into GoogleCloudPlatform:main Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants