Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable host name checking #313

Open
enocom opened this issue May 2, 2024 · 0 comments · May be fixed by #283
Open

Enable host name checking #313

enocom opened this issue May 2, 2024 · 0 comments · May be fixed by #283
Assignees
@enocom
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@enocom
Copy link
Member

enocom commented May 2, 2024

The AlloyDB server certificates have SANs for all connection paths (private, public, and PSC).

We should enable host name checking as a result.

alloydb-python-connector/google/cloud/alloydb/connector/refresh.py

Lines 89 to 91 in f290619

# TODO: Set check_hostname to True to verify the identity in the
# certificate once PSC DNS is populated in all existing clusters.
self.context.check_hostname = False

@enocom enocom added priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels May 2, 2024
@enocom enocom self-assigned this May 2, 2024
@enocom enocom linked a pull request May 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enocom enocom

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: have ssl handshake check hostname GoogleCloudPlatform/alloydb-python-connector
1 participant
@enocom