Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate having user_agent support driver version #205

Open
jackwotherspoon opened this issue Jan 12, 2024 · 1 comment
Open

Investigate having user_agent support driver version #205

jackwotherspoon opened this issue Jan 12, 2024 · 1 comment
Assignees
@jackwotherspoon
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@jackwotherspoon
Copy link
Collaborator

Now that we support asyncpg and pg8000 we should try to add the driver being used by the connector's client to the user agent string

https://github.com/GoogleCloudPlatform/alloydb-python-connector/blob/main/google/cloud/alloydb/connector/client.py#L28
@jackwotherspoon jackwotherspoon added priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern. labels Jan 12, 2024
@jackwotherspoon jackwotherspoon self-assigned this Jan 12, 2024
@jackwotherspoon
Copy link
Collaborator Author

Added support for driver user agents as part of #191 but it is not a long-term solution. Since we support only asyncpg through the AsyncConnector class and only pg8000 through the Connector it works currently. But it would not if we were to add support for a new driver so it needs improving still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jackwotherspoon jackwotherspoon

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jackwotherspoon