New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use built-in batch grouping transform #1418
Use built-in batch grouping transform #1418
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1418 +/- ##
============================================
- Coverage 40.93% 40.87% -0.06%
+ Complexity 2808 2798 -10
============================================
Files 739 737 -2
Lines 42855 42828 -27
Branches 4582 4579 -3
============================================
- Hits 17542 17508 -34
- Misses 23814 23823 +9
+ Partials 1499 1497 -2
|
a51a20a
to
a228987
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@liferoad I think this is ready for you to review. |
Can you check the failed tests? https://github.com/GoogleCloudPlatform/DataflowTemplates/pull/1418/checks?check_run_id=25124983697 |
@liferoad |
Can you rebase it? |
This does not change anything in practice, since edge and custom query targets share the same default value.
@liferoad now rebased |
https://github.com/GoogleCloudPlatform/DataflowTemplates/actions/runs/9171539329?pr=1418 The job running on runner nokill-gitactions-runner-7jhd has exceeded the maximum execution time of 180 minutes. Is this caused by the new tests you added? |
9b5416f
into
GoogleCloudPlatform:main
Fixes #1416