Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prerendering is not working #390

Open
kireerik opened this issue Jun 17, 2023 · 5 comments
Open

Prerendering is not working #390

kireerik opened this issue Jun 17, 2023 · 5 comments

Comments

@kireerik
Copy link

and (when enabled) there is no prefetching either.

example:

 
To Reproduce

Enable the option around this line:

 
Version:

  • OS w/ version: Windows 10
  • Browser w/ version: Google Chrome 114.0.5735.110
@kireerik kireerik mentioned this issue Jun 17, 2023
2 tasks
@hadyan
Copy link
Contributor

hadyan commented Jun 19, 2023

Thanks for the details @kireerik.

I added the prerenderAndPrefetch option to example/index/index/site/index/main.js#L10

image

and it looks like the resume page is still prefetched as expected, speculation rules is injected and the page is prerendered:

image

Just a side note that the latest quicklink release has not included the update to remove 1 prerender limit, hence the resume page is not included in the speculation rules.

Did you try with prerenderAndPrefetch or any other option to enable prerendering mode?

@kireerik
Copy link
Author

I tried the prerender option. Now I see that the script is added in that case as well. However it seems like the (added) page is not prerendered.

Can you release

?

@kireerik
Copy link
Author

performance.getEntriesByType('navigation')[0].activationStart is 0 (related article section: https://developer.chrome.com/blog/prerender-pages/#detecting-prerender-in-javascript)

@hadyan
Copy link
Contributor

hadyan commented Jul 3, 2023

I tried the prerender option. Now I see that the script is added in that case as well. However it seems like the (added) page is not prerendered.

@kireerik Great to see that the prerender option works to add the speculation rules on your page. Which tool did you use to observe whether the page is prerendered successfully. This new preloading panel in DevTools and testing it in Canary will be the most reliable way to test.

Can you release

?

As for the release, hope it can be released soon too. @XhmikosR / @addyosmani have you planned for the next release yet? Thank you!

@XhmikosR
Copy link
Collaborator

XhmikosR commented Aug 14, 2023

@hadyan: IIRC, @addyosmani wanted to make the next version a minor release (I personally would land any other breaking changes and make it v3.0.0 to be safe since the dist file filenames have changed IIRC).

I don't have push rights on npm AFAICT so it's up to @addyosmani to cut the new version :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants