Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark peerDependencies as optional #363

Open
XhmikosR opened this issue Apr 20, 2023 · 0 comments · May be fixed by #421
Open

Mark peerDependencies as optional #363

XhmikosR opened this issue Apr 20, 2023 · 0 comments · May be fixed by #421
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request

Comments

@XhmikosR
Copy link
Collaborator

XhmikosR commented Apr 20, 2023 •
edited

AFAICT react, react-dom and route-manifest are only needed if one is using react.

Thus, wouldn't it make more sense to mark these peerDependencies as optional?

We would only need to update README.md and the site instructions, apart from package.json. Not sure if it'll be worth adding a try/catch in the react code, if we update the instructions.

It'll be a breaking change, though.

/CC @addyosmani
@XhmikosR XhmikosR added enhancement New feature or request dependencies Pull requests that update a dependency file labels Apr 20, 2023
@XhmikosR XhmikosR linked a pull request May 9, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@XhmikosR