Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra] [Minor] Address build system deprecation warnings #206

Open
addyosmani opened this issue Nov 16, 2020 · 3 comments
Open

[Infra] [Minor] Address build system deprecation warnings #206

addyosmani opened this issue Nov 16, 2020 · 3 comments
Assignees

Comments

@addyosmani
Copy link
Collaborator

In particular, see the deprecation warnings around options.mainFields:

warning "microbundle > rollup-plugin-typescript2@0.19.3" has incorrect peer dependency "rollup@>=0.68.0".
[4/4] 🔨  Building fresh packages...
warning Your current version of Yarn is out of date. The latest version is "1.22.5", while you're on "1.22.4".
info To upgrade, run the following command:
$ curl --compressed -o- -L https://yarnpkg.com/install.sh | bash
$ yarn run -s build
node-resolve: setting options.module is deprecated, please override options.mainFields instead
node-resolve: setting options.jsnext is deprecated, please override options.mainFields instead
node-resolve: setting options.module is deprecated, please override options.mainFields instead
node-resolve: setting options.jsnext is deprecated, please override options.mainFields instead
node-resolve: setting options.module is deprecated, please override options.mainFields instead
node-resolve: setting options.jsnext is deprecated, please override options.mainFields instead
Build "quicklink" to dist:
        992 B: quicklink.js.gz
        846 B: quicklink.js.br
        995 B: quicklink.mjs.gz
        846 B: quicklink.mjs.br
       1061 B: quicklink.umd.js.gz
        906 B: quicklink.umd.js.br
✨  Done in 39.70s.
@addyosmani addyosmani self-assigned this Nov 16, 2020
@addyosmani
Copy link
Collaborator Author

Upgrading to latest microbundle addresses this issue, but I'm seeing some local test failures that will require further debugging. Will do so before landing a fix here.

@XhmikosR
Copy link
Collaborator

XhmikosR commented Apr 3, 2023

This is fixed on master, feel free to tweak the microbundle properties later :)

@XhmikosR XhmikosR closed this as completed Apr 3, 2023
@XhmikosR XhmikosR reopened this Apr 3, 2023
@addyosmani
Copy link
Collaborator Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants