Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The README file in this repo has some bad links - [404:NotFound] #204

Open
MrCull opened this issue Nov 5, 2020 · 2 comments
Open

The README file in this repo has some bad links - [404:NotFound] #204

MrCull opened this issue Nov 5, 2020 · 2 comments
Labels
bug Something isn't working docs Documentation good first issue Good for newcomers

Comments

@MrCull
Copy link

MrCull commented Nov 5, 2020

Describe the bug
The markup version of the readme that is displayed in the main page for this repo contains the following links:
Status code [404:NotFound] - Link: https://keyword-2-ecd7b.firebaseapp.com/
Status code [404:NotFound] - Link: https://github.com/GoogleChromeLabs/quicklink/blob/master/#custom-ignore-patterns

(The links in the readme’s markdown may appear different to the link above extracted from the markup)

To Reproduce
Find the links under "demo" & "custom ignore patterns list"

Expected behavior
Links should work!

Version:
n/a

Additional context, screenshots, screencasts

The bad link was found by a tool I very recently created as part of an new experimental hobby project: https://github.com/MrCull/GitHub-Repo-ReadMe-Dead-Link-Finder
I (a human) verified that this link is broken (for me) and have manually logged this Issue (i.e. this Issue has not been created by a bot).
If this has been in any way helpful then please consider giving the above Repo a Star.

If you have any feedback on the information provided here, or on the tool itself, then please feel free to share your thoughts and pass on the feedback.

@addyosmani addyosmani added bug Something isn't working docs Documentation good first issue Good for newcomers labels Nov 16, 2020
@passionInfinite
Copy link

@addyosmani Can I please take this issue for a start?

@XhmikosR
Copy link
Collaborator

@addyosmani AFAICT only the demo link is broken. Should we just link to https://getquick.link/demo/?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs Documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants