Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work on Firefox anymore #95

Open
Qhilm opened this issue Sep 14, 2023 · 5 comments
Open

Does not work on Firefox anymore #95

Qhilm opened this issue Sep 14, 2023 · 5 comments

Comments

@Qhilm
Copy link

Qhilm commented Sep 14, 2023

Currently, the only way to get it to work on Firefox is:

  1. load the link to text fragment
  2. it fails
  3. click on the "link to text fragment" add-on icon
  4. Error is displayed "INVALID_SELECTION: The selection provided could not be used."
  5. reload web page in Firefox
  6. it works, text fragment is highlighted.

These steps must be repeated for every link, hence it's not very usable anymore.

Example link: https://blog.chromium.org/2019/12/chrome-80-content-indexing-es-modules.html#:~:text=ECMAScript%20Modules%20in%20Web%20Workers

Firefox 117.0.1
macOS 13.5.2

@tomayac
Copy link
Member

tomayac commented Sep 14, 2023

I'm not sure what changed on the Firefox side. It was working just fine, but I can confirm that it stopped working on Firefox 117 now. It uses manifest v3, so maybe there's some problem there? You can see the recent commits if you want to investigate.

There's a known issue on Chrome (and probably Firefox), where extension contexts can't use the Async Clipboard API because it's not focused. In Chrome, this is tracked as https://crbug.com/1404835.

@RokeJulianLockhart
Copy link

RokeJulianLockhart commented Sep 19, 2023

#95 (comment)

@Qhilm, it has worked for me using https://download.opensuse.org/repositories/openSUSE:/Factory/standard/x86_64/MozillaFirefox-122.0-3.2.x86_64.rpm on cpe:/o:opensuse:tumbleweed from :20230915 to :20240131.

  1. 2023-09-19.19-02-59.mp4
  2. Screenshot_20230919_185952

@johnmaguire
Copy link

Firefox 119 on macOS Sonoma. I no longer see the "Copy link to selected text" context menu item.

@Qhilm
Copy link
Author

Qhilm commented Nov 3, 2023

Firefox 119 on macOS Sonoma. I no longer see the "Copy link to selected text" context menu item.

you may have to click on the add-on icon once.

@budak7273
Copy link

Seems to be working without any additional steps for me on Windows firefox 121.0.1 (64-bit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants