Skip to content
This repository has been archived by the owner on Jul 8, 2020. It is now read-only.

Return a score and valid bash when page is 404 #28

Open
riderx opened this issue Mar 29, 2018 · 3 comments
Open

Return a score and valid bash when page is 404 #28

riderx opened this issue Mar 29, 2018 · 3 comments

Comments

@riderx
Copy link

riderx commented Mar 29, 2018

on our travis when the url is wrong lighthouse validate the page, that cause false positive in Pr review :/
@ebidel
Copy link
Contributor

ebidel commented Mar 29, 2018

What do you mean when the URL is wrong?

@riderx
Copy link
Author

riderx commented Mar 30, 2018

When our deploy fail and our website return 404 lighthouse did his work so travis ci valid our Pr

@ebidel
Copy link
Contributor

ebidel commented Mar 30, 2018 •
edited

When you run LH from the CLI on a 404 page, it gives you this and exits the process:

screen shot 2018-03-30 at 8 59 15 am

What are you seeing?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ebidel @riderx