Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

Typo / mistake in Learn PWA > Service Workers #10331

Closed
julamb opened this issue Aug 13, 2023 · 1 comment · May be fixed by #10332
Closed

Typo / mistake in Learn PWA > Service Workers #10331

julamb opened this issue Aug 13, 2023 · 1 comment · May be fixed by #10332
Labels
P2 A normal priority task. This is the default for most issues.

Comments

@julamb
Copy link

julamb commented Aug 13, 2023 •
edited

The Registering a service worker sections states:

Before a service worker takes control of your page, it must be registered for your PWA. That means the first time a user comes to your PWA, network requests will not go directly to your server because the service worker is not yet in control of your pages.

That seems to be a mistake: on first load, the requests won't be intercepted by the PWA, and will go directly to your server.
@julamb julamb added the P2 A normal priority task. This is the default for most issues. label Aug 13, 2023
@julamb julamb mentioned this issue Aug 13, 2023
Open
@dstmarthe
Copy link
Collaborator

Thanks for raising this. We’re moving to a new platform and so we’ll fix this over there. I’ve moved the issue to our new tracker and you can see it at https://issuetracker.google.com/issues/297891063

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
P2 A normal priority task. This is the default for most issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix typo / mistake in Learn PWA > Service Workers julamb/web.dev
2 participants
@julamb @dstmarthe