You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using Amp4Body_TD, if setDataSize does not have the right dimensions, GooFit can still appear to function and produces a fit which is wrong but according to Minuit is convergent. For example in my branch jcob_test_branch I have added extra observables. setDataSize should therefore be set to setDataSize(numEventsToFit,9) but if I set this to setDataSize(numEventsToFit,8) things work as I have described previously. This should not happen, so I recommend adding a check to make sure the dimensions are correct or at least adding some kind of warning.
Edit: Will add a reproducible script and links to code
The text was updated successfully, but these errors were encountered:
When using Amp4Body_TD, if
setDataSize
does not have the right dimensions, GooFit can still appear to function and produces a fit which is wrong but according to Minuit is convergent. For example in my branchjcob_test_branch
I have added extra observables.setDataSize
should therefore be set tosetDataSize(numEventsToFit,9)
but if I set this tosetDataSize(numEventsToFit,8)
things work as I have described previously. This should not happen, so I recommend adding a check to make sure the dimensions are correct or at least adding some kind of warning.Edit: Will add a reproducible script and links to code
The text was updated successfully, but these errors were encountered: