Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GooFit still works with incorrect memory allocation (Amp4Body_TD) #289

Open
jcob95 opened this issue Nov 24, 2021 · 0 comments
Open

GooFit still works with incorrect memory allocation (Amp4Body_TD) #289

jcob95 opened this issue Nov 24, 2021 · 0 comments

Comments

@jcob95
Copy link
Collaborator

jcob95 commented Nov 24, 2021

When using Amp4Body_TD, if setDataSize does not have the right dimensions, GooFit can still appear to function and produces a fit which is wrong but according to Minuit is convergent. For example in my branch jcob_test_branch I have added extra observables. setDataSize should therefore be set to setDataSize(numEventsToFit,9) but if I set this to setDataSize(numEventsToFit,8) things work as I have described previously. This should not happen, so I recommend adding a check to make sure the dimensions are correct or at least adding some kind of warning.

Edit: Will add a reproducible script and links to code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants