-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake 3.16 build issues #239
Comments
The links for the PDF libraries are different in 3.16; this part disappears:
I think this is why 3.16 is producing the missing symbols seen on Conda-forge and in #234. Any quick thoughts as to why this may have started happening, @robertmaynard? It was fine in CMake 3.8-3.15. ImportError: /__w/GooFit/GooFit/build/goofit/_goofit.cpython-36m-x86_64-linux-gnu.so: undefined symbol:
__cudaRegisterLinkedBinary_41_tmpxft_00000ff9_00000000_6_FLATTE_cpp1_ii_06041a8e (FWIW: every PDF's cudaRegisterLinkedBinary symbol is missing) |
Can you try 3.16.2 and see if that works? If it does it means that the following fix is at fault: |
I've started a build with 3.16.2, though I think this fix was back ported into 3.15.7, and I tested that one when 3.15.7 came out and it worked (I was quite worried when I saw it in the changes for 3.15.7, but it passed). |
No, it did not build with 3.16.2. It builds correctly with 3.15.7, which has the same fix back ported. |
@henryiii Do you have time to make a small test case that can reproduce this issue? That would really help me track down the root issue, and propose a solution ( and fix CMake if necessary ). |
I'll try, but I'm traveling this week. Now that I know roughly what is different it will be easier to set up. |
This may be an issue with CMake 3.16. Here's the methodology:
(and likewise for 3.16.4)
And the differences:
cmake315.log
cmake316.log
The text was updated successfully, but these errors were encountered: