Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for 2.3.0 #226

Open
2 of 6 tasks
henryiii opened this issue Jan 26, 2020 · 1 comment
Open
2 of 6 tasks

Proposal for 2.3.0 #226

henryiii opened this issue Jan 26, 2020 · 1 comment

Comments

@henryiii
Copy link
Member

henryiii commented Jan 26, 2020

I'd like to recommend or make a few changes and release a new 2.3.0 version of GooFit in 2-3 weeks. These are the things I'd like to do that warrant the larger version bump:

  • Drop support for older CMake. This is a common source of bugs, a huge maintenance burden and not hard for users to install. Drop support for CMake < 3.9 (< 3.12 even better) #106
  • Drop support for CUDA < 8.0. 8.0 is already rather old.
  • Drop (explicit?) support for arch 2.0. We should require 3.0 or 3.5, I believe (newer versions of CUDA drop support for older arches too, I think)
  • Make a strong effort to support CUDA 9.2-10.2 (the current versions of CUDA). 8.0 is getting too old to be our most recommended version.
  • Include any patches needed for the WIP Conda-forge version. GooFit package conda-forge/staged-recipes#10654 (Done in 2.2.3)
  • Work on compile speed, support UNITY builds and maybe PCH.

And, mostly done:

  • Better support for Python installs (proper PEP 517 CMake usage, for example)
  • Fixes for some common build issues
@henryiii
Copy link
Member Author

Note: A few more old-CUDA workarounds are left over:

if(GOOFIT_DEVICE STREQUAL CUDA AND NOT NEW_CUDA)
target_include_directories(_goofit PUBLIC ${CUDA_INCLUDE_DIRS})
endif()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant