Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added gizmos to help align interactable joints #585

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Malcolmnixon
Copy link
Collaborator

@Malcolmnixon Malcolmnixon commented Dec 10, 2023

This PR resolves request #584 by adding gizmos to align interactable hinges, sliders, and joysticks. This does cause minor breakage in that:

  • New origin nodes have been introduced where the ranges are visualized
  • Testing showed Y-Axis inversion on the slider and joystick

Demonstration Video

Gizmos.mp4

Slider Gizmo

image

Hinge Gizmo

image

Joystick Gizmo

image

This PR resolves request GodotVR#584 by adding gizmos to align interactable hinges, sliders, and joysticks. This does cause minor breakage in that:
- New origin nodes have been introduced where the ranges are visualized
- Testing showed Y-Axis inversion on the slider and joystick
@BastiaanOlij BastiaanOlij added this to the 4.4.0 milestone Dec 11, 2023
@BastiaanOlij BastiaanOlij added enhancement New feature or request breaking Breaking change labels Dec 11, 2023
Copy link
Member

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, can merge when we've got 4.3.1 out.

@BastiaanOlij BastiaanOlij linked an issue Dec 11, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interactables need 3D Gizmos to assist in alignment
2 participants