Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credentials candidate from heuristic interprets keycodes as US keyboard layout #430

Open
pmcRTR opened this issue Dec 23, 2022 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed investigate Needs more thought / experience
Milestone

Comments

@pmcRTR
Copy link

pmcRTR commented Dec 23, 2022

My RDP client machine and my backend RDP server are set for UK keyboard layout.

I noticed that password credentials keycodes are interpreted by PyRDP as if a US keyboard layout is in use.

For example, if I log in using a password like H@ppy, PyRDP logs will instead report that password attempt as being H"ppy

Is there any way for PyRDP to interpret password attempts based on the keyboard layout of the connecting client machine so that passwords always match what was attempted?

@obilodeau obilodeau added enhancement New feature or request help wanted Extra attention is needed investigate Needs more thought / experience labels Dec 23, 2022
@obilodeau obilodeau added this to the v1.3.0 milestone Dec 23, 2022
@obilodeau
Copy link
Member

Right now I believe that PyRDP converts the scan codes it receives into virtual key codes and those virtual key codes are not translated further into a keyboard layout if one is specified by the client.

This would be an interesting feature to add. Here is some context that could help implementation:

@obilodeau obilodeau modified the milestones: v1.3.0, v2.0.1 Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed investigate Needs more thought / experience
Projects
None yet
Development

No branches or pull requests

2 participants