Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sound id's not always generated properly #1096

Closed
SHADOWDANCH opened this issue May 8, 2020 · 3 comments
Closed

Sound id's not always generated properly #1096

SHADOWDANCH opened this issue May 8, 2020 · 3 comments

Comments

@SHADOWDANCH
Copy link
Contributor

SHADOWDANCH commented May 8, 2020

Current method of generating minecraft sound id from Sound bukkit enum not always working correctly. For example unable to play shulker open sound because it contains _ in middle part of the name and instead block.shulker_box.open we will get block.shulker.box.open


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@mastercoms
Copy link
Member

Good catch, I guess we can add an exceptions list + tests? I think it works well for the majority and saves time. Not sure where we can get a list of valid vanilla names though for tests.

@mastercoms
Copy link
Member

We're considering using https://github.com/Articdive/ArticData for this.

@mastercoms
Copy link
Member

Duplicate of #519.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants