Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Painting registry [$10] #23

Open
mastercoms opened this issue Sep 15, 2019 · 0 comments
Open

Painting registry [$10] #23

mastercoms opened this issue Sep 15, 2019 · 0 comments
Labels
bounty data A feature involving internal representations of blocks, items, properties, and more. non-essential A feature that is part of the 1.13 update, but not required for the 1.13 platform update. serialization A feature involving data serialization/deserialization.
Projects

Comments

@mastercoms
Copy link
Member

mastercoms commented Sep 15, 2019

This issue is part of the 1.13.x compatibility Epic.

All contributions are subject to the Glowstone CLA. In short, contributions must not contain any content (code or otherwise) copied from,
inspired by or based upon content from Mojang or third-party projects that are based on such content (CraftBukkit, Spigot, Forge, ...).


Description:

Paintings are now described with a namespaced ID under minecraft:motive. So we should replace our constants for that, and read from data.

Reference Documentation:

https://wiki.vg/Data_Generators#Registries_report
https://minecraft.gamepedia.com/Painting
https://minecraft.gamepedia.com/Java_Edition_1.13/Flattening#Painting_Motives

Relevant Code:

https://github.com/GlowstoneMC/Glowstone/blob/1.13/src/main/java/net/glowstone/entity/objects/GlowPainting.java
https://github.com/GlowstoneMC/Glowstone/blob/1.13/src/main/java/net/glowstone/block/itemtype/ItemPainting.java
https://github.com/GlowstoneMC/Glowstone/blob/1.13/src/main/java/net/glowstone/io/entity/PaintingStore.java

Related to:

#4


There is a $10 open bounty on this issue. Add to the bounty at Bountysource.

@mastercoms mastercoms added non-essential A feature that is part of the 1.13 update, but not required for the 1.13 platform update. serialization A feature involving data serialization/deserialization. data A feature involving internal representations of blocks, items, properties, and more. labels Sep 15, 2019
@mastercoms mastercoms added this to Backlog in 1.13 Sep 15, 2019
@mastercoms mastercoms changed the title Painting registry Painting registry [$10] Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty data A feature involving internal representations of blocks, items, properties, and more. non-essential A feature that is part of the 1.13 update, but not required for the 1.13 platform update. serialization A feature involving data serialization/deserialization.
Projects
1.13
  
Backlog
Development

No branches or pull requests

1 participant