Bug: jsx indentation with 'switch' statements

[cgong-strade]

@prettydiff ,
The indentations starting from line 3 are not quite right, please look into this.

before:

function getDisplay(value) {
  switch (value) {
    case 12 :
      return 'Within 1 year';
    case 24 :
      return 'Within 2 years';
    case 999 :
      return 'Any';
  }
}

after:

function getDisplay(value) {
  switch (value) {
  case 12 :
    return 'Within 1 year';
  case 24 :
    return 'Within 2 years';
  case 999 :
    return 'Any';
  }
}

[prettydiff]

No, this is intentional. Originally when I started building JavaScript beautifiers they were primarily tooled towards the JSLint style guide, because at the time it was the complete and easily testable style guide around for JavaScript. This is what JSLint recommends.

I could put an option to indent the case sections as nested blocks, but most of the style guides are moving towards guidance of strong opposition to switch/case.

[cgong-strade]

Thanks for the reply. I have noticed that in js files atom-beautify would actually indent the case by two space from switch. We are currently using jsx and js files together and experiencing eslint conflicts between the two. Can you reconcile them or advice. Thanks

[prettydiff]

I can hide the default behavior behind an option.

[cgong-strade]

yeah, it would be great if you can provide the option.

[axelson]

+1 for the ability to configure the switch/case indentation behavior in Javascript.

[calidion]

it is problem solved? i run into this problem too.

[prettydiff]

@calidion Could you create a debug.md file using Atom Beautify and paste that into a gist? It will provide me all the details I need to reproduce the problem.

[nakamorichi]

Still no possibility to set switch/case indentation in JavaScript (or even better, autoload the SwitchCase setting from .eslintrc) ?

[Glavin001]

Does the Js Beautify also have this issue? If so, please create an issue over at https://github.com/beautify-web/js-beautify and reference back to this Issue. Thanks.

[nakamorichi]

Just realized that the jslint-happy setting was the culprit. Turned it off and the indentation got fixed. However, would still be nice to have possibility to set this directly from .eslintrc, as suggested in #897 .

[stale]

This issue has been automatically marked as stale because it has not had recent activity. If this is still an issue, please add a comment. It will be closed if no further activity occurs. Thank you for your contributions.