Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify which angle is needed for DirectionalBias #512

Closed
adehecq opened this issue Apr 29, 2024 · 1 comment · Fixed by #526
Closed

Clarify which angle is needed for DirectionalBias #512

adehecq opened this issue Apr 29, 2024 · 1 comment · Fixed by #526
Labels
documentation Improvements or additions to documentation

Comments

@adehecq
Copy link
Member

adehecq commented Apr 29, 2024

The docstring at this line is not clear enough.
My understanding is that we need to provide the angle with reference to the x axis, in clockwise direction. That's what I inferred from looking at the results of that line (clever way of not interpolating the data btw 😉), providing the wrong angle means one may look at across-track instead of along-track direction.
Ii not clarified, I think it's more intuitive for most people to see it as the angle w.r.t. the y axis, because satellite images are typically only slightly rotated compared to that axis.

@adehecq adehecq added the documentation Improvements or additions to documentation label Apr 29, 2024
@rhugonnet
Copy link
Contributor

Closed by #526

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants