Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Make pre-built binaries standalone #3587

Open
fuero opened this issue Jun 12, 2023 · 8 comments
Open

[Improvement] Make pre-built binaries standalone #3587

fuero opened this issue Jun 12, 2023 · 8 comments
Assignees
Milestone

Comments

@fuero
Copy link

fuero commented Jun 12, 2023

Is your improvement request related to a problem? Please describe.
I'd like to use GitVersion standalone without the .Net Framework present

Detailed Description

Provide another set of binaries that are built like this (example for Linux):

  dotnet publish \
    src/GitVersion.App/GitVersion.App.csproj \
    --runtime linux-x64 \
    --framework net6.0 \
    --sc \
    -o "${srcdir}/build" \
    /p:DebugType=None \
    /p:DebugSymbols=false \
    -p:PublishTrimmed=false \
    -p:PublishReadyToRun=true \
    -p:PublishSingleFile=true \
    -p:IncludeNativeLibrariesForSelfExtract=true

I'm building GitVersion this way in the AUR package I created: https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=gitversion

@arturcic
Copy link
Member

Hey @fuero we dropped support for .net framework already, all the artifacts are build with the .net sdk only. You can see the way we currently build for the linux binaries we publish with the release:

var platform = context.Environment.Platform.Family;
.

I wonder if there is a way we can integrate the publishing of the AUR package into our release pipelines. Can you describe how a AUR package publishing happens? We can have something similar to how we build for homebrew

@fuero
Copy link
Author

fuero commented Jun 12, 2023

Sorry, I was mistaken. The binaries the homebrew package produces apparantly can't run without a .Net dependency, the binaries offered on Github are fine.

As for AUR - They're published by the author via git, see https://wiki.archlinux.org/title/Arch_User_Repository#Submitting_packages

@arturcic
Copy link
Member

if I can see it correctly it's on a different repository - https://aur.archlinux.org/gitversion.git/ and there you specify how to build that. Question, is it possible to have for example the github repo instead (https://github.com/GitTools/GitVersion) and then we can add support for the scripts we need in order to be able to release new versions? Also I saw you're the author of the package, can we include the maintainers also there?

@fuero
Copy link
Author

fuero commented Jun 12, 2023

Here's an example of something similar: https://jamiemagee.co.uk/blog/maintaining-aur-packages-with-renovate/
That person keeps the packages they're managing in a Github Repo and selectively pushes updates to the AUR git repo via Github actions.
If you want to do this, I'll happily sign over maintainership :-)

@arturcic
Copy link
Member

To be honest I'd be happy to add support for that

@fuero
Copy link
Author

fuero commented Jun 12, 2023

Great - hit me up again once you're set up!

@arturcic
Copy link
Member

Great - hit me up again once you're set up!

Deal

@arturcic arturcic self-assigned this Jun 12, 2023
@arturcic arturcic added this to the 6.x milestone Jun 12, 2023
@arturcic arturcic added stale and removed stale labels Jun 30, 2023
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. After 30 days from now, it will be closed if no further activity occurs.

@github-actions github-actions bot added the stale label Sep 29, 2023
@arturcic arturcic removed the stale label Sep 29, 2023
@arturcic arturcic added stale and removed stale labels Oct 30, 2023
@HHobeck HHobeck modified the milestones: 6.x, 7.x Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants