Desktop App #812
Replies: 54 comments
-
|
This will be amazing :-) |
Beta Was this translation helpful? Give feedback.
-
|
I got a basic version of the app running on osx. Lots of stuff to do in-order for this to work properly though -
The good news is that all of these tasks need to be done regardless of the desktop version. A large number are required to publish this on fdroid, and the responsive UI will also help GitJournal be more usable on Tablets and ChromeOS. |
Beta Was this translation helpful? Give feedback.
-
|
So it sounds like this issue might deprecate #45 ...? |
Beta Was this translation helpful? Give feedback.
-
Nah. I would like to have both Desktop and Web Version. The Web requires more work as we cannot use git directly or communicate via ssh. One would need to integrate with the GitHub and GitLab specific APIs. |
Beta Was this translation helpful? Give feedback.
-
|
So I'll definitely need a web or desktop option, as it is really the only thing holding me back from using this as my "One true notebook". You have done some amazing work here @vHanda with GitJournal. Such a refined experience, like you actual are dog-fooding this app yourself daily. If you could get even a beta Windows App out there I'd use it right away. |
Beta Was this translation helpful? Give feedback.
-
Thanks. I really appreciate your kind words. I've been a bit demotivated lately, so your comment really helps. I'll try to get the desktop version out as soon as I can. |
Beta Was this translation helpful? Give feedback.
-
|
@vHanda your job is great. Make sure that even few users see it with a big difference in their daily lives. |
Beta Was this translation helpful? Give feedback.
-
|
Desktop App for which platform(s)? Since the connection to the GIT is necessary in realtime, maybe the web app is sufficient. Synchronization seems to be the issue for me. |
Beta Was this translation helpful? Give feedback.
-
All 3? Linux, Mac and Windows. I don't use Windows at all, so that will be a bit more challenging. The issue with the web version is that it will only work with GitHub or Gitlab, and I will have to rewrite large parts to use their specific APIs, instead of normal SSH + git or even http + git. Also, with the web-version, since GitHub and Gitlab don't have fine grained permissions, you will need to give GitJournal access to read+write to all your repos (public and private) I'm the author of GitJournal, and I don't feel comfortable giving it access to all my repos. I wonder how others will feel. |
Beta Was this translation helpful? Give feedback.
-
|
Yeah, I thought I noticed that the SSH key way had more targeted
permissions, not requiring unlimited API permission like the https style.
Is that true Vishesh?
…On Fri, Jul 31, 2020, 7:43 AM Vishesh Handa ***@***.***> wrote:
Desktop App for which platform(s)? Since the connection to the GIT is
necessary in realtime, maybe the web app is sufficient. Synchronization
seems to be the issue for me.
All 3? Linux, Mac and Windows. I don't use Windows at all, so that will be
a bit more challenging.
The issue with the web version is that it will only work with GitHub or
Gitlab, and I will have to rewrite large parts to use their specific APIs,
instead of normal SSH + git or even http + git.
Also, with the web-version, since GitHub and Gitlab don't have fine
grained permissions, you will need to give GitJournal access to read+write
to all your repos (public and private)
I'm the author of GitJournal, and I don't feel comfortable giving it
access to all my repos. I wonder how others will feel.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#137 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQBLNTVOJ7ORJ66NBSUYLXLR6KU57ANCNFSM4NAVI5MQ>
.
|
Beta Was this translation helpful? Give feedback.
-
Classically Git can be accessed via 2 transport mechanisms -
However this https method cannot be easily used over the browser because of certain restrictions - You can read more about it over here - https://github.com/isomorphic-git/isomorphic-git#cors-support Therefore in order to access Git over a browser, we need to use the custom APIs provided by Github and Gitlab. These custom APIs (as far as I can tell) do not allow fine grained permissions. It's an all or nothing approach - link. GitHub (not GitLab) does have a newer concept called "GitHub Apps" which in theory can be granted lesser permissions than all or nothing - via the typical OAuth, but it's not clear to me if this would give per repository access. The docs aren't very clear. Alternatively, there is always an option that users could create a new GitHub account and give that account write access to that one repo, and then give GitJournal full access to that alternative account. This sounds very cumbersome though. |
Beta Was this translation helpful? Give feedback.
-
|
Yeah this is all stuff they ran into in trying to do it browser based on
taniarascia/takenote#165 . Thanks for walking us
through it and providing links Vishesh 👍🕵️♀️👨🏫
…On Fri, Jul 31, 2020 at 8:38 AM Vishesh Handa ***@***.***> wrote:
Yeah, I thought I noticed that the SSH key way had more targeted
permissions, not requiring unlimited API permission like the https style.
Is that true Vishesh?
Classically Git can be accessed via 2 transport mechanisms -
- SSH - Fine grained permissions are possible via GitHub and GitLab
- HTTPS - Fine grained permissions also possible via GitHub and GitLab
However this https method cannot be easily used over the browser because
of certain restrictions - You can read more about it over here -
https://github.com/isomorphic-git/isomorphic-git#cors-support
Therefore in order to access Git over a browser, we need to use the custom
APIs provided by Github and Gitlab. These custom APIs (as far as I can
tell) do not allow fine grained permissions. It's an all or nothing
approach - link
<https://docs.github.com/en/developers/apps/scopes-for-oauth-apps>.
GitHub (not GitLab) does have a newer concept called "GitHub Apps" which
in theory can be granted lesser permissions than all or nothing - via the
typical OAuth, but it's not clear to me if this would give per repository
access. The docs
<https://docs.github.com/en/developers/apps/differences-between-github-apps-and-oauth-apps>
aren't very clear.
Alternatively, there is always an option that users could create a new
GitHub account and give that account write access to that one repo, and
then give GitJournal full access to that alternative account. This sounds
very cumbersome though.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#137 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQBLNTRI4E7IVIRM5HJTQK3R6K3MHANCNFSM4NAVI5MQ>
.
|
Beta Was this translation helpful? Give feedback.
-
A humble opinion: for as long as GitJournal is a filesystem-based, Markdown-based note app with git integration, there's no need for "Desktop App", because for that, a user can use:
Please don't spread thin, please make a good mobile note-taking app, period. All other areas are overcrowded already. |
Beta Was this translation helpful? Give feedback.
-
|
@pfalcon Let me extend that: |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the feedback. I haven't worked much on the desktop app in a while. I won't be giving it much/any love for at least a few months. There are too many things todo on the mobile app. @tionis : Could you please give me a rough example of what kind of standard you would like. it's not clear to me. |
Beta Was this translation helpful? Give feedback.
-
|
I have good news. I've been using the desktop app for the past week. I can release a beta version soon. I've only used it on osx so far. Also, it requires you to have "git" installed. |
Beta Was this translation helpful? Give feedback.
-
|
Seems reasonable, and you can add basic instructions for installing git as
a pre-req, but I'm guessing your audience will 95%+ already have it
installed :).
This is exciting news! I'm definitely interested!
…On Fri, Jun 4, 2021, 6:53 PM Vishesh Handa ***@***.***> wrote:
I have good news. I've been using the desktop app for the past week. I can
release a beta version soon. I've only used it on osx so far.
Also, it requires you to have "git" installed.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#137 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQBLNTV3RDRAYCFVHVZXYADTRFKPTANCNFSM4NAVI5MQ>
.
|
Beta Was this translation helpful? Give feedback.
-
Good news, indeed. P. S. I think for most people syncing functionality will be enough on a desktop. Just because there are so many text editing tools already out there that can be used separately. |
Beta Was this translation helpful? Give feedback.
-
|
I agree with @glow12121. I want a file watcher, not an app. For as many notetaking apps as there are, the only thing really missing is file syncing. I would prefer to choose my own desktop app (sublime text?, text edit?, github?) It shouldn't matter what the app is. The only thing I am missing is this: when I save, I want the note to sync across devices without overwriting. GitJournal is an attractive mobile app because it understands that git or something similar is needed for proper sync to avoid files overwriting each other when they connect to the internet. The missing piece: when I update a file from my laptop (with any app), I want it to push the changes to git without having to run any commands or do any extra steps. CMD+S (saving the file) itself should be what triggers the git commands. I think what that means is that I want a file watcher, not an app. There is a useful git script on the GJ docs here. But how do I get it to run on save? To me, THAT is the missing piece, not a desktop app. The reason that the GJ mobile app is important is that consumers can't run scripts and file watchers from their phones. So, with a phone you need an app like GJ. With a desktop, you should be free to use any text editor, but also saving the file should sync But doesn't the file watcher sound like a separate project from GJ? I'm willing to make it happen, but I might need some guidance. I'm a web developer, so I'd need some advice on how to implement a file watcher and make it distributable (i.e. easy for others to get and use) |
Beta Was this translation helpful? Give feedback.
-
|
Rough Update. Steps are missing for the desktop app -
(Both of these steps will involve calling a process on the desktop)
@nth-chile : I agree with you. However, I think we should track this in another bug report. If it helps, I've already started working on an electron app which (for now) polls the folder. Could you please open another bug report? Once the basic scaffolding is in place, I can add watching. PS: I know electron has its issues, but Flutter isn't mature enough for this right now. If anyone wants to help, I would love a better icon. For me this is something independent of GitJournal, as it's just is just to sync to another git repo. The green folder is the temporary icon.
|
Beta Was this translation helpful? Give feedback.
-
Awesome @vHanda, is it in a separate repo? |
Beta Was this translation helpful? Give feedback.
-
I haven't pushed it so far, the code is todos and my experiments while I learn electron. Please just open the bug in this repo for now. It's just to create the Desktop App which polls / watches for changes. |
Beta Was this translation helpful? Give feedback.
-
|
The final repo will be here - https://github.com/GitJournal/git-auto-sync . I've pushed some of the changes. It's just me experimenting right now. My local copy has a lot of uncommitted changes. |
Beta Was this translation helpful? Give feedback.
-
|
Created feature request #515 |
Beta Was this translation helpful? Give feedback.
-
|
Update: I never landed up figuring out the osx code signing, so we don't yet have a build you guys can use. However, I did create an AppImage for Linux. It's built with each commit on the CI. Eg - https://github.com/GitJournal/GitJournal/runs/3191857379 (Look at the artifacts). Please keep in mind that GitJournal needs a lot of UI work to make it more "responsive". Right now it clearly feels like a mobile app just running on the desktop. |
Beta Was this translation helpful? Give feedback.
-
|
For macOS you will need an Apple Developer Account: https://learnappmaking.com/how-to-create-a-free-apple-developer-account/ (no need to pay for the AppStore stuff) Then see here for example: https://wiki.lazarus.freepascal.org/Code_Signing_for_macOS#Using_codesign_to_sign_your_application |
Beta Was this translation helpful? Give feedback.
-
|
Hi. I've done the basic codesigning for MacOS. However, I'm still figuring out the notarization, until then you'll have to explicitly allow GitJournal - Eg -
You'll have to go to "Security and Privacy" and explicitly allow GitJournal.
You can get it from the CI. Eg - https://github.com/GitJournal/GitJournal/actions/runs/1165846131 |
Beta Was this translation helpful? Give feedback.
-
|
Thanks, you're awesome! ps. That's why I'm delaying the Big Sur update (viz. notarization)... |
Beta Was this translation helpful? Give feedback.
-
|
Just want to say, it's really cool seeing the effort going into this project. Going with Flutter seems like an awesome choice, given their continued efforts to try and support Desktop, arm64, etc. as time goes on. I picture a world where I can one day use GitJournal on a PinePhone :) |
Beta Was this translation helpful? Give feedback.
-
|
Just poking my head in, has there been any movement on this? Thanks! |
Beta Was this translation helpful? Give feedback.
-
It might be even easier to provide a desktop app of GitJournal over a web-app via go-flutter.
Beta Was this translation helpful? Give feedback.
All reactions