Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Label cell selected state should keep label color #762

Closed
BasThomas opened this issue Oct 26, 2017 · 3 comments
Closed

Label cell selected state should keep label color #762

BasThomas opened this issue Oct 26, 2017 · 3 comments
Labels
🐛 bug Unintended behaviour within the app low priority Low priority issue/feature
Projects

Comments

@BasThomas
Copy link
Collaborator

GitHawk Upload by Sherlouk

Bug Report Dump (Auto-generated)
Version 1.12.0 (1106)
Device: iPhone 7 Plus (iOS 11.0.3)
TestFlight: true
@BasThomas BasThomas added the 🐛 bug Unintended behaviour within the app label Oct 26, 2017
@rnystrom rnystrom added the low priority Low priority issue/feature label Oct 27, 2017
@ajfigueroa
Copy link
Contributor

One way I've seen this done is by setting the background appearance of the button as an image via setBackgroundImage(_:for:). You'd need to be able to create a UIImage from a UIColor.

Alternatively, you can override the cell's setHighlighted:animated and setSelected:animated which I'm not a fan of but also works as seen here

Hopefully, this helps whoever tackles this issue in the future 👍

@BasThomas
Copy link
Collaborator Author

If someone wants to tackle this in the future; the same thing is happening in #905.

@rnystrom rnystrom added this to Low priority in Bugs Aug 13, 2018
@ghost
Copy link

ghost commented Sep 24, 2018

Old issue? The labels scene seems very different now.

I can't reproduce this in commit 966cb1a dated 27 Sep 2018 on master

Xcode Version 10.0 (10A254a)
Simulator iPhone XR iOS 12

simulator screen shot - iphone xr - 2018-09-24 at 08 26 37

Bugs automation moved this from Low priority to Closed Sep 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛 bug Unintended behaviour within the app low priority Low priority issue/feature
Projects
Bugs
Closed
Development

No branches or pull requests

3 participants