Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

URL Schemes & Opener Support #418

Closed
Sherlouk opened this issue Sep 24, 2017 · 16 comments
Closed

URL Schemes & Opener Support #418

Sherlouk opened this issue Sep 24, 2017 · 16 comments
Assignees
Labels
🆕 feature request A feature being requested to be added, not yet approved

Comments

@Sherlouk
Copy link
Member

Opener is an iOS app which basically lets the user choose where to open links, basically takes advantage of URL schemes.

We should add support for basic URL schemes to deeplink to certain UI within the app. Namely:

freetime://issue/rnystrom/GitHawk/418 would go to this issue!
freetime://repository/rnystrom/GitHawk
freetime://notifications

(Also aware that we may want to rename our URL Scheme??)

Once we add this feature, we should add our app to the Opener manifest. It's not a perfect solution, but it would be a nice companion app to start opening GitHub stuff in our app rather than Safari!

@Sherlouk Sherlouk added 🆕 feature request A feature being requested to be added, not yet approved mid labels Sep 24, 2017
@Sherlouk Sherlouk self-assigned this Sep 24, 2017
@Sherlouk
Copy link
Member Author

Also worth noting that this will go slightly hand-in-hand with any work on home screen widgets, apple watch stuff, etc hence why I've given it a mid priority and not low!

@BasThomas
Copy link
Collaborator

BasThomas commented Jun 6, 2018

I want to take a look at this soon :)

Eg. open repo or filing an issue in one

Sent with GitHawk

@BasThomas BasThomas self-assigned this Jun 6, 2018
@timonus
Copy link
Contributor

timonus commented Jul 18, 2018

Would happily integrate into Opener once there’s a URL scheme 😊

Sent with GitHawk

@rnystrom
Copy link
Member

URL scheme architecture is on my mind for the next release!

Sent with GitHawk

@BasThomas BasThomas removed their assignment Oct 16, 2018
@BasThomas
Copy link
Collaborator

Somebody could take a look at this now we have routing in place :)

@palmin
Copy link
Contributor

palmin commented Oct 30, 2018

I plan to link to repositories and issues in GitHawk as soon as the App Store version of GitHawk supports this.

image

@palmin
Copy link
Contributor

palmin commented Nov 7, 2018

@rnystrom: Is there anything I can do to assist?

I'm not sure if the url format representing routes is going to change and I'm also not able to tell if the app currently looks at URL's when launched.

But if you give me some specific tasks I can move this forward.

@rnystrom
Copy link
Member

rnystrom commented Nov 7, 2018

@palmin the App Store version should be able to handle deep links now using the route scheme in GitHawkRoutes

Sent with GitHawk

@palmin
Copy link
Contributor

palmin commented Nov 7, 2018

@rnystrom I would expect
freetime://RepoRoute?owner=GitHawkApp&branch=master&repo=GitHawk
to open the overview screen for GitHawk but it opens the app without going to any particular screen.

Am I misunderstanding how these deep links are supposed to work?

@rnystrom
Copy link
Member

rnystrom commented Nov 8, 2018

Hmm no that should be right. Let me fire up a sample app to try and debug

Sent with GitHawk

@rnystrom rnystrom self-assigned this Nov 8, 2018
@timonus
Copy link
Contributor

timonus commented Nov 11, 2018

Awesome, just tried this out and seems to work! I've got https://github.com/timonus/OpenerManifest/tree/githawk waiting in the wings for when this version of GitHawk makes it to the App Store.

@palmin
Copy link
Contributor

palmin commented Nov 11, 2018

deep-loop

@rnystrom
Copy link
Member

You guys 😍😭🙏

Sent with GitHawk

@rizwankce
Copy link
Collaborator

For the shortcut fans out there, have created a shortcut as well to open the github repo.

https://www.icloud.com/shortcuts/61bf54353a914d62983f9e1c1bf7a02a

I'll update it to have option to open issues/PR and from clipboard as well. For now you can open it from any share sheet which have urls.

Sent with GitHawk

@jryio
Copy link

jryio commented Nov 12, 2018

@rizwankce you're amazing

@timonus
Copy link
Contributor

timonus commented Nov 16, 2018

It's lit fam 🔥

https://github.com/timonus/OpenerManifest/compare/a2b50cd7...c38dc3c7
https://twitter.com/OpenerApp/status/1063257573795651585

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🆕 feature request A feature being requested to be added, not yet approved
Projects
None yet
Development

No branches or pull requests

7 participants