New error alert

[rnystrom]

iPhone X makes the status bar alert outdated. Need to find something new. Any ideas?

[Sherlouk]

Same style of alert but pops up as a toast above tab bar or cover nav bar? Or we just address it on a case by case basic and try to give more contextual error messages

[rnystrom]

Really like the toast idea. Lets go hunting!

_{Sent with GitHawk}

[Sherlouk]

https://github.com/devxoul/Toaster - Very quick search is showing this, gives appareance overrides so with a couple factory methods we can distinguish between errors/other messages?

[kimdv]

I have made a pull request #483 that implements https://github.com/devxoul/Toaster

I looks nice, maybe some more minor layout changes

[kimdv]

As @rnystrom mentioned in #483 we should make our own. 😄

[rnystrom]

Started work on this on the flight home. Will have something pretty soon! Came up w/ some fun ideas. Building it in a way so it can be a separate pod. Love @BasThomas's idea.

[rnystrom]

Quick preview of what I've got in action:

Features:

• Totally configurable (text, font, colors, layout spacing)
• Interactive
  • Rubber-band effect when swiping up
  • Swipe down to dismiss

TODO:

• Auto dismiss after duration
• Delegate when tapping button
• Fix multi-line label
• Tune physics

Learned quite a bit about UIDynamics and Auto Layout w/ this. Been fun!

[BasThomas]

Oh wow, looks great! Looking forward to seeing how you implemented it 😀

_{Sent with GitHawk}

[Sherlouk]

That image was very confusing from the app's point of view, it just looks like an image 😅

Looks great though! (when looked at on GitHub)

[BasThomas]

Yeah, the “Quick preview of what I’ve got in action:” definitely helped though. Gif support please! 😁

[Sherlouk]

It's weird though because NY photo viewer supports GIFs, so... it should've worked 🤔 Maybe we have to enable it some how

https://github.com/rnystrom/GitHawk/blob/master/Podfile.lock#L17-L22

[BasThomas]

Oh that's weird. No idea.

[Sherlouk]

@BasThomas Looks like you have to add ANIMATED_GIF_SUPPORT as a compiler flag to get it working. If you get five minutes 😉

https://github.com/NYTimes/NYTPhotoViewer/blob/master/NYTPhotoViewer/NYTScalingImageView.m#L21

[BasThomas]

Can we close this now, @rnystrom?

[BasThomas]

@Sherlouk that gives me a "no such file or directory" 😂
What am I missing?

[Sherlouk]

For reasons I don't understand, ya have to prefix them with -D so -DANIMATED_GIF_SUPPORT

[BasThomas]

🤔, it seems like it should already work without though: https://github.com/NYTimes/NYTPhotoViewer/blob/14458e8ed8065c3cf31fe0744db9fd4c506e4cfe/NYTPhotoViewer.podspec#L25

[Sherlouk]

I don't understand because we don't even specify a subspec: https://github.com/rnystrom/GitHawk/blob/master/Podfile#L12

and it doesn't specify a default subspec 🤔 Maybe reference the NYTPhotoViewer/AnimatedGifSupport directly?

[Sherlouk]

Also @BasThomas https://bugs.swift.org/browse/SR-909 -- Is this applicable?

[BasThomas]

Doesn't look like it. #if ANIMATED_GIF_SUPPORT is true.

[Sherlouk]

Not too familiar with ObjC, is #ifdef handled differently?

Is it getting to https://github.com/NYTimes/NYTPhotoViewer/blob/master/NYTPhotoViewer/NYTScalingImageView.m#L125?

[BasThomas]

Let's move this over to #75