Collection view in repos do not respect safe area

[BasThomas]

Bug Report Dump (Auto-generated)

Version 1.27.1 (1546622353)
Device: iPhone X (iOS 12.1.2)
TestFlight: true

[RJ-Clegg]

I can take a look at this.

[ivenprillwitz]

is this still an issue? i could help :)

[RJ-Clegg]

is this still an issue? i could help :)

Only managed to get time to look at this now. I'll let you know if I have any issues. Thanks!

[RJ-Clegg]

@BasThomas - How did you get the UITabBar to disappear?
I've gone to the exact repo from the screenshot - via search and from bookmarks. The UITabBar remains in place; even whilst scrolling.

With the UITabBar on screen; this issue isn't reproducible.

[j-f1]

If you open it from Notifications, the tab bar is not present.

[RJ-Clegg]

If you open it from Notifications, the tab bar is not present.

Thanks, will check it out

[BasThomas]

And from the navigation bar in an issue 😊

_{Sent with GitHawk}

[j-f1]

Ah yeah, only from the navbar in an issue. I wonder — should this just be worked around by always showing the tab bar?

[RJ-Clegg]

And from the navigation bar in an issue 😊

Sent with GitHawk

Thanks, I am able to reproduce it easily enough now. I'll have a fix soon when I get home this evening.

[BasThomas]

Ah yeah, only from the navbar in an issue. I wonder — should this just be worked around by always showing the tab bar?

@j-f1 not sure, but I feel that should / can be tackled separately.

_{Sent with GitHawk}

[j-f1]

⏩ #2666

[LucianoPAlmeida]

Just taking a quick look at this one in the RepositoryViewController, seems like is an issue with the XLPagerTabStrip dependency. Here xmartlabs/XLPagerTabStrip#722